This repository was archived by the owner on Mar 1, 2019. It is now read-only.
Only import implementations data from non-api crates #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses some of the concerns discussed here: #49
nrc
reviewed
Jun 13, 2017
This is a breaking change to the API, thus increasing the version number.
|
It is now possible to perform the filtering while retrieving the data. I even made the filtering option. Although this is now an API breaking change. |
nrc
reviewed
Jun 15, 2017
| @@ -568,13 +579,19 @@ pub struct PerCrateAnalysis { | |||
| def_names: HashMap<String, Vec<Id>>, | |||
| ref_spans: HashMap<Id, Vec<Span>>, | |||
| globs: HashMap<Span, Glob>, | |||
| impls: HashMap<Id, Vec<Span>>, | |||
| impls: HashMap<Id, Vec<SpanApi>>, | |||
There was a problem hiding this comment.
Could we add a single bool to the crate, rather than one to each span? If not, I'd prefer to use a tuple here rather than add another struct
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some of the concerns discussed here:
#49