Update to digital v2 since original digital OutputPin has been deprecated #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamwaffles
requested changes
May 19, 2019
There was a problem hiding this comment.
Hi, thanks for the PR (and the issue)! The v2 traits seem to be causing issues for quite a few people, like here and here.
The jury's out on what to do going forward, so for now my suggestion would be to remove the #![deny(warnings)] crate attribute. I think this will still cause a spew of warnings, but at least this driver will compile again whilst maintaining compatibility with the old traits. The migration path hasn't been great for the v2 stuff IMO, but it is what it is 🙂.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address issue #81