Switch back to MonoTimer from HAL #357
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @therealprof (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
This switches back from the local replacement for MonoTimer from 814c051 to the one re-added with HAL release 0.8.0. MonoTimers interface changed in the meantime so this commit takes this into account as well.
sirhcel
force-pushed
the
monotimer-from-hal
branch
from
7767eb7 to
dc1c8a5
Compare
|
A fixed HAL got released with 0.8.0 meanwhile. So rubberduck203/stm32f3-discovery#44 is on the way for updating the BSP. |
|
Not sure after all this time of the relevance? Would probably need to be updated for HAL 1.x |
|
You are absolutely right. This draft PR has been dry-aging and with rust-embedded/wg#759 on the horizon this looks like too much effort for restoring nostalgia. |
|
Sorry we never got to this. We'll set up a maintenance plan to prioritize fixes on the current Discovery book going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to stm32-rs/stm32f3xx-hal#247 it got removed accidentially and has been resurrected. There is no need for the local copy from here.