Skip to content

Remove Qei trait as it has an unconstrained associated type #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,23 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- `i2c`: traits now enforce all impls on the same struct have the same `Error` type.
- `i2c`: unify all traits into a single `I2c` trait.

### Removed
- Traits with unconstrained associated types and their modules (See: [#324], [#354]):
- `capture::Capture`
- `pwm::Pwm`
- `pwm::PwmPin`
- `qei::Qei`
- `timer::Cancel`
- `timer::CountDown`
- `timer::Periodic`
- `watchdog::Disable`
- `watchdog::Enable`
- `watchdog::Watchdog`


[#324]: https://github.com/rust-embedded/embedded-hal/pull/324/
[#354]: https://github.com/rust-embedded/embedded-hal/pull/354

## [v1.0.0-alpha.6] - 2021-11-19

*** This is (also) an alpha release with breaking changes (sorry) ***
Expand Down
1 change: 0 additions & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,6 @@ pub mod can;
pub mod delay;
pub mod digital;
pub mod i2c;
pub mod qei;
pub mod serial;
pub mod spi;

Expand Down
82 changes: 0 additions & 82 deletions src/qei.rs

This file was deleted.