Skip to content

Fix LineEvent timestamp doc #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2023
Merged

Fix LineEvent timestamp doc #70

merged 4 commits into from
Jun 5, 2023

Conversation

mpi3d
Copy link
Contributor

@mpi3d mpi3d commented Apr 21, 2023

Fix documentation on LineEvent::timestamp().

According to the Linux documentation, the timestamp is CLOCK_MONOTONIC by default: gpio.h#L286.

Please see #68 comment.

@posborne
Copy link
Member

The default clock used depends on the kernel version. torvalds/linux@26d060e notes that this change to the default was made with kernel 5.7, so a note to that effect may be nice.

@mpi3d
Copy link
Contributor Author

mpi3d commented Apr 29, 2023

The default clock used depends on the kernel version. torvalds/linux@26d060e notes that this change to the default was made with kernel 5.7, so a note to that effect may be nice.

Ok, thanks, I added a new commit for that.

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!
bors r+

bors bot added a commit that referenced this pull request May 19, 2023
70: Fix LineEvent timestamp doc r=eldruin a=mpi3d

Fix documentation on `LineEvent::timestamp()`.

According to the Linux documentation, the timestamp is `CLOCK_MONOTONIC` by default: [gpio.h#L286](https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/gpio.h#n286).

Please see [#68 comment](#68 (comment)).

Co-authored-by: Matthieu CHARETTE <[email protected]>
@bors
Copy link
Contributor

bors bot commented May 19, 2023

Build failed:

@eldruin
Copy link
Member

eldruin commented May 19, 2023

Sorry, could you also raise the MSRV to 1.56 and note that change in the changelog?

@mpi3d
Copy link
Contributor Author

mpi3d commented May 19, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented May 19, 2023

🔒 Permission denied

Existing reviewers: click here to make mpi3d a reviewer

@mpi3d
Copy link
Contributor Author

mpi3d commented May 19, 2023

Anyway: done

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
bors r+

bors bot added a commit that referenced this pull request May 19, 2023
70: Fix LineEvent timestamp doc r=eldruin a=mpi3d

Fix documentation on `LineEvent::timestamp()`.

According to the Linux documentation, the timestamp is `CLOCK_MONOTONIC` by default: [gpio.h#L286](https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/gpio.h#n286).

Please see [#68 comment](#68 (comment)).

Co-authored-by: Matthieu CHARETTE <[email protected]>
@bors
Copy link
Contributor

bors bot commented May 19, 2023

Build failed:

@mpi3d
Copy link
Contributor Author

mpi3d commented May 19, 2023

Guessing it needs 1.59

@eldruin
Copy link
Member

eldruin commented May 22, 2023

It seems we have some more problems :/

@mpi3d
Copy link
Contributor Author

mpi3d commented May 22, 2023

@eldruin I force pushed a commit to fix it. Can you trigger a new build please?

@eldruin
Copy link
Member

eldruin commented May 26, 2023

I fixed our CI in #71. Could you rebase this?

@mpi3d
Copy link
Contributor Author

mpi3d commented May 26, 2023

Done

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for everything!
bors r+

@bors bors bot merged commit e636a82 into rust-embedded:master Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants