-
Notifications
You must be signed in to change notification settings - Fork 37
Fix LineEvent timestamp doc #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The default clock used depends on the kernel version. torvalds/linux@26d060e notes that this change to the default was made with kernel 5.7, so a note to that effect may be nice. |
Ok, thanks, I added a new commit for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
bors r+
70: Fix LineEvent timestamp doc r=eldruin a=mpi3d Fix documentation on `LineEvent::timestamp()`. According to the Linux documentation, the timestamp is `CLOCK_MONOTONIC` by default: [gpio.h#L286](https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/gpio.h#n286). Please see [#68 comment](#68 (comment)). Co-authored-by: Matthieu CHARETTE <[email protected]>
Build failed: |
Sorry, could you also raise the MSRV to 1.56 and note that change in the changelog? |
bors r+ |
🔒 Permission denied Existing reviewers: click here to make mpi3d a reviewer |
Anyway: done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
bors r+
70: Fix LineEvent timestamp doc r=eldruin a=mpi3d Fix documentation on `LineEvent::timestamp()`. According to the Linux documentation, the timestamp is `CLOCK_MONOTONIC` by default: [gpio.h#L286](https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/gpio.h#n286). Please see [#68 comment](#68 (comment)). Co-authored-by: Matthieu CHARETTE <[email protected]>
Build failed: |
Guessing it needs |
It seems we have some more problems :/ |
@eldruin I force pushed a commit to fix it. Can you trigger a new build please? |
I fixed our CI in #71. Could you rebase this? |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for everything!
bors r+
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
Fix documentation on
LineEvent::timestamp()
.According to the Linux documentation, the timestamp is
CLOCK_MONOTONIC
by default: gpio.h#L286.Please see #68 comment.