Skip to content

CI update + update MSRV to 1.65.0 #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2024
Merged

CI update + update MSRV to 1.65.0 #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 20 additions & 63 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,41 +1,41 @@
on:
push:
branches: [ staging, trying, master ]
pull_request:
push: # Run CI for all branches except GitHub merge queue tmp branches
branches-ignore:
- "gh-readonly-queue/**"
pull_request: # Run CI for PRs on any branch
merge_group: # Run CI for the GitHub merge queue

name: CI
name: Build

env:
RUSTFLAGS: '--deny warnings'

jobs:
ci-linux:
name: CI
build:
runs-on: ubuntu-latest
strategy:
matrix:
rust: [stable]
FEATURES: ["", "--features=async-tokio", "--features=mio-evented"]
TARGET:
- aarch64-unknown-linux-gnu
- aarch64-unknown-linux-musl
- arm-unknown-linux-gnueabi
- arm-unknown-linux-gnueabihf
- armv7-unknown-linux-gnueabihf
- i686-unknown-linux-gnu
- i686-unknown-linux-musl
- mips-unknown-linux-gnu
Copy link
Contributor

@ryankurte ryankurte May 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update! why is mips removed here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All mips targets are Tier 3 now, meaning they don't get official builds anymore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you had me look at this. I'd just copied this list from gpio-cdev without a critical eye. The loongarch64 is Tier 3 too, no reason to mention it in the list even commented out. And powerpc64 is tier 1 and would make sense to support. I'll fix this up.

- mips64-unknown-linux-gnuabi64
- mips64el-unknown-linux-gnuabi64
- mipsel-unknown-linux-gnu
- powerpc-unknown-linux-gnu
# - powerpc64-unknown-linux-gnu
- powerpc64-unknown-linux-gnu
- powerpc64le-unknown-linux-gnu
- riscv64gc-unknown-linux-gnu
- s390x-unknown-linux-gnu
- x86_64-unknown-linux-gnu
- x86_64-unknown-linux-musl

include:
# MSRV
- rust: 1.46.0
- rust: 1.65.0
TARGET: x86_64-unknown-linux-gnu

# Test nightly but don't fail
Expand All @@ -58,37 +58,11 @@ jobs:
command: build
args: --target=${{ matrix.TARGET }} ${{ matrix.FEATURES }}

- name: Test
uses: actions-rs/cargo@v1
with:
use-cross: true
command: test
args: --target=${{ matrix.TARGET }} ${{ matrix.FEATURES }}

ci-linux-msrv:
name: CI
runs-on: ubuntu-latest
strategy:
matrix:
rust: [1.46.0]
FEATURES: ["", "--features=async-tokio", "--features=mio-evented"]
TARGET:
- x86_64-unknown-linux-gnu

steps:
- uses: actions/checkout@v2
- uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: ${{ matrix.rust }}
target: ${{ matrix.TARGET }}
override: true

- name: Build
- name: Build all features
uses: actions-rs/cargo@v1
with:
command: build
args: --target=${{ matrix.TARGET }} ${{ matrix.FEATURES }}
args: --target=${{ matrix.TARGET }} --all-features

- name: Test
uses: actions-rs/cargo@v1
Expand All @@ -97,29 +71,12 @@ jobs:
command: test
args: --target=${{ matrix.TARGET }} ${{ matrix.FEATURES }}

ci-macos:
name: CI
runs-on: macos-11

strategy:
matrix:
rust: [stable, 1.46.0]
TARGET: [x86_64-apple-darwin]

steps:
- uses: actions/checkout@v2

- uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: ${{ matrix.rust }}
target: ${{ matrix.TARGET }}
override: true

- uses: actions-rs/cargo@v1
- name: Test all features
uses: actions-rs/cargo@v1
with:
command: build
args: --target=${{ matrix.TARGET }}
use-cross: true
command: test
args: --target=${{ matrix.TARGET }} --all-features

checks:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -152,7 +109,7 @@ jobs:
- uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: 1.46.0
toolchain: 1.65.0
components: clippy

- uses: actions-rs/clippy-check@v1
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## [master] - Unreleased

### Changed

- Minimum supported Rust version updated to 1.65.0

## [0.6.1] - 2021-11-22

### Changed
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ sysfs_gpio

[![Build Status](https://github.com/rust-embedded/rust-sysfs-gpio/workflows/CI/badge.svg)](https://github.com/rust-embedded/rust-sysfs-gpio/actions)
[![Version](https://img.shields.io/crates/v/sysfs-gpio.svg)](https://crates.io/crates/sysfs-gpio)
![Minimum Supported Rust Version](https://img.shields.io/badge/rustc-1.46+-blue.svg)
![Minimum Supported Rust Version](https://img.shields.io/badge/rustc-1.65+-blue.svg)
[![License](https://img.shields.io/crates/l/sysfs-gpio.svg)](https://github.com/rust-embedded/rust-sysfs-gpio/blob/master/README.md#license)

- [API Documentation](https://docs.rs/sysfs_gpio)
Expand Down Expand Up @@ -85,7 +85,7 @@ The following features are planned for the library:

## Minimum Supported Rust Version (MSRV)

This crate is guaranteed to compile on stable Rust 1.46.0 and up. It *might*
This crate is guaranteed to compile on stable Rust 1.65.0 and up. It *might*
compile with older versions but that may change in any new patch release.

## Cross Compiling
Expand Down
Loading