add operational notes #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japaric
requested review from
dylanmckay,
jcsoo,
thejpster and
a team
as code owners
ryankurte
approved these changes
Aug 10, 2018
|
LGTM! Thanks for writing this all out. |
jamesmunns
approved these changes
Aug 10, 2018
dylanmckay
approved these changes
Aug 11, 2018
japaric
added a commit
to dvc94ch/riscv-rt
that referenced
this pull request
Aug 11, 2018
japaric
added a commit
to dvc94ch/riscv
that referenced
this pull request
Aug 11, 2018
adamgreig
approved these changes
Aug 11, 2018
adamgreig
requested changes
Aug 11, 2018
| [team]: https://github.com/rust-embedded/wg#the-cortex-m-team | ||
| ``` | ||
|
|
||
| - If the repository uses CI, configure bors. Add a `.github/bors.toml` file with these contents: |
There was a problem hiding this comment.
I think this should just be bors.toml, not inside .github/?
There was a problem hiding this comment.
That's where I have been putting it so far but I've been told that putting it inside .github also works. I think is better to make it less visible since most people (both contributors and reviewers) won't be modifying it.
There was a problem hiding this comment.
Fine with me. Should we move it on the existing repositories then?
There was a problem hiding this comment.
Yes. I also need to add block_labels = ["needs-decision"] to most of them.
adamgreig
approved these changes
Aug 12, 2018
|
Seems like discussion is complete, merging manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #148 (comment).
I'm putting them in a PR for now regardless of wherever we decide to put them in the end because that seems like a better place than in my head :-).
cc @jamesmunns @adamgreig