This repository was archived by the owner on Aug 16, 2021. It is now read-only.
Split backtrace and std features up. #128
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows depending on std Fail implementations without depending on the backtrace crate. Note that with this, both the 'backtrace' and 'std' features must be enabled in order to access backtrace functionality. There is no current way to depend on the 'std' feature from the 'backtrace' feature in cargo, as it is named after a dependency.
|
Planning to make a breaking change, will probably wrap this up in that. |
|
Alright, thanks! |
|
Fixed with #144, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows depending on std Fail implementations without depending on the backtrace crate.
There are two caveats. First, in this PR both
backtraceandstdmust be enabled in order for someone to use the backtrace functionality. Second, this might be a breaking change if someone depended ondefault-features = false, features = ["std"]in the past, and relied on std depending on backtrace to bring it in.This changes the travis CI configuration to test with std and backtrace enabled separately so as to ensure correctness.
Closes #127.