Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

Add support for Android NDK 16 #65

Conversation

kanerogers
Copy link

This PR adds support for Android NDK 16, as discussed in rust-lang/rust#31119 (comment) 😄

@alexcrichton
Copy link
Contributor

Perhaps this could be tested out first? I think that this'll also need to install an API level 16 emulator and also switch to using that emulator instead of the arm-18 emulator.

@kanerogers
Copy link
Author

No problem Alex! Just point me in the right direction and I'll get it done.

On Mon, Mar 7, 2016 at 6:16 PM Alex Crichton [email protected]
wrote:

Perhaps this could be tested out first? I think that this'll also need to
install an API level 16 emulator and also switch to using that emulator
instead of the arm-18 emulator.


Reply to this email directly or view it on GitHub
#65 (comment)
.

@alexcrichton
Copy link
Contributor

Ah yeah sure. What you'll basically want to do is emulate what the bots themselves do. Our buildbot has a ton of builders, but you're most likely only interested in the android one. You can take a look at a recent successful build to get an idea of how we run the build.

Basically what you'll want to do is:

  1. Modify the slave images here to install a level 16 NDK
  2. Modify the image to have a level 16 emulator (may need to install some more things, see install-sdk.sh
  3. Spin up the image
  4. Clone Rust
  5. Configure rust for cross compilation
  6. Run the build
  7. Start up right emulator in the background
  8. Run the tests in the emulator

The builder should show you the commands that are needed to run all this, but once that's all up and running this should be good to go! We'll likely want to land the standard library changes first, and then I'll merge these changes here, test them in dev, merge them to master, and deploy them to prod.

@kanerogers
Copy link
Author

Got it. Leave it with me. :- )

Thanks so much for all the help!

On Mon, Mar 7, 2016 at 6:36 PM Alex Crichton [email protected]
wrote:

Ah yeah sure. What you'll basically want to do is emulate what the bots
themselves do. Our buildbot http://buildbot.rust-lang.org/ has a ton of
builders, but you're most likely only interested in the android one
http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t. You
can take a look at a recent successful build
http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/8272
to get an idea of how we run the build.

Basically what you'll want to do is:

  1. Modify the slave images here to install a level 16 NDK
  2. Modify the image to have a level 16 emulator (may need to install
    some more things, see install-sdk.sh
  3. Spin up the image
  4. Clone Rust
  5. Configure rust for cross compilation
  6. Run the build
  7. Start up right emulator in the background
  8. Run the tests in the emulator

The builder should show you the commands that are needed to run all this,
but once that's all up and running this should be good to go! We'll likely
want to land the standard library changes first, and then I'll merge these
changes here, test them in dev, merge them to master, and deploy them to
prod.


Reply to this email directly or view it on GitHub
#65 (comment)
.

@brson
Copy link
Contributor

brson commented Mar 7, 2016

Neat!

@rillian
Copy link
Contributor

rillian commented Apr 22, 2016

I presume #99 would resolve this too.

@alexcrichton
Copy link
Contributor

I'm hoping to add API level 9 support soon, so hopefully that'll be more than enough to target API level 16, so I'm gonna close this for now. Thanks though for the PR @kanerogers!

@kanerogers
Copy link
Author

No worries, Alex! Sorry I didn't get a chance to take this any further. :- (

On Wed, May 25, 2016 at 3:46 AM Alex Crichton [email protected]
wrote:

I'm hoping to add API level 9 support soon, so hopefully that'll be more
than enough to target API level 16, so I'm gonna close this for now. Thanks
though for the PR @kanerogers https://github.com/kanerogers!


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#65 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants