This repository was archived by the owner on Mar 19, 2024. It is now read-only.
Test code provided by alexheretic to filter variable type #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pr & example. Do you think we should provide a config to toggle this? I wonder if anyone wants the variables in the outline. I added a comment inline. But this definitely looks like an improvement for the usability of the outline. |
alexheretic
suggested changes
Mar 4, 2018
lib/index.js
Outdated
| @@ -577,6 +577,20 @@ class RustLanguageClient extends AutoLanguageClient { | |||
| throw new Error("failed to start server: " + e) | |||
| } | |||
| } | |||
|
|
|||
| provideOutlines() { | |||
There was a problem hiding this comment.
I think we should add a comment on this method just briefly explaining what we're doing & the motivation for filtering variables.
|
I don't think local variables are useful in outline views of static typed languages. This is the behaviour we find in Eclipse JDT, atom-ide-java and atom-ide-csharp, etc. If anyone files a bug about it, which I think unlikely, we can then add the config toggle. Otherwise, in my opinion, it's unnecessary complexity. |
alexheretic
approved these changes
Mar 6, 2018
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit in combination with the changes in RLS categorization make the outline view more useful and fixes #58.
These are three outlines for the RLS's rustc.rs file. The first is the previous state where there are many local variables between methods, the second one just filters the local variables in RLS and the third uses the new categorization and filter variables on ide-rust. Notice methods and fields are now properly shown.
