Skip to content

hash 'CFG_RELEASE_CHANNEL' in metadata for crates #4179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Keruspe
Copy link
Contributor

@Keruspe Keruspe commented Jun 16, 2017

This avoids having conflicting hashes between two rustc channels when a
library has not changed

This requires rust-lang/rust#42696 to work properly as part of rustbuild, otherwise the build system can get confused and try to access libraries with a wrong hash.

This avoids having conflicting hashes between two rustc channels when a
library has not changed

Signed-off-by: Marc-Antoine Perennou <[email protected]>
@rust-highfive
Copy link

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Thanks for the PR! I feel though that this is the wrong way to fix the problem. This environment variable is only relevant for rust-lang/rust and not all the other cargo projects? Can a fix be applied to src/bootstrap/bin/rustc.rs instead of Cargo?

@Keruspe
Copy link
Contributor Author

Keruspe commented Jun 19, 2017

I'm currently looking into it.
I was blindly focusing on the hash, but maybe modifying src/bootstrap/bin/rustc.rs to insert the channel in the metadata flag would be acceptable?
For example, instead of libbitflags-1199f1aa498b4cd1.rlib we'd have libbitflags-1199f1aa498b4cd1-stable.rlib and libbitflags-1199f1aa498b4cd1-beta.rlib.

If that's an acceptable solution it sure seems to be easily doable

@Keruspe Keruspe closed this Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants