[core/workspace] Create WorkspaceRootConfig #4594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
This is the codemod I mentioned. I'm working on the fix of the current glob-based implementation, and then switching to gitignore-based logic. What do you think? |
Create `WorkspaceRootConfig`, which knows its `root_dir` and lists of `members` and `excludes`, to answer queries on which paths are a member and which are not.
Plus some little codemod.
|
@bors: r+ Looks great! |
|
📌 Commit fd07cfd has been approved by |
bors
added a commit
that referenced
this pull request
Oct 10, 2017
[core/workspace] Create WorkspaceRootConfig Create `WorkspaceRootConfig`, which knows its `root_dir` and lists of `members` and `excludes`, to answer queries on which paths are a member and which are not. ---- This is the first step of the fix, that's only a codemod to put together the relevant parts : `workspace.members`, `workspace.excludes`, and the `root_dir` (where `members` and `excludes` are relative to). There's no logic change in this PR to keep review easier. The added tests are commented out, because they fail with the current logic. The next step to get these steps to pass. Tracker: <#4089> Old PR: <#4297>
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create
WorkspaceRootConfig, which knows itsroot_dirand lists ofmembersandexcludes, to answer queries on which paths are a memberand which are not.
This is the first step of the fix, that's only a codemod to put together the relevant parts :
workspace.members,workspace.excludes, and theroot_dir(wheremembersandexcludesare relative to). There's no logic change in this PR to keep review easier.The added tests are commented out, because they fail with the current logic. The next step to get these steps to pass.
Tracker: #4089
Old PR: #4297