Fix another issue of poisoning too eagerly #5307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extends the fix in rust-lang#5288 by moving the logic added farther up in the loop over package dependencies. This means that we won't recursively look at optional/dev path dependencies which aren't members of the workspace. This should fix the new issue that came up in rust-lang#5257 Closes rust-lang#5257
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ We’ll need to back port this to beta as well :) |
|
📌 Commit c7a1105 has been approved by |
bors
added a commit
that referenced
this pull request
Apr 6, 2018
Fix another issue of poisoning too eagerly This commit extends the fix in #5288 by moving the logic added farther up in the loop over package dependencies. This means that we won't recursively look at optional/dev path dependencies which aren't members of the workspace. This should fix the new issue that came up in #5257 Closes #5257
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
that referenced
this pull request
Apr 6, 2018
[beta] Fix another issue of poisoning too eagerly Backport of #5307
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Apr 6, 2018
This is a backport of rust-lang/cargo#5307
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Apr 8, 2018
[beta] Update Cargo This is a backport of rust-lang/cargo#5307
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extends the fix in #5288 by moving the logic added farther up in the
loop over package dependencies. This means that we won't recursively look at
optional/dev path dependencies which aren't members of the workspace. This
should fix the new issue that came up in #5257
Closes #5257