-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix fetching crates on old versions of libcurl. #6383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Oh dear, good catch! Currently though the performance of fetches does actually rely on PIPEWAIT because we issue all HTTP requests to libcurl simultaneously and it would otherwise flood crates.io with new TCP connections (one per crate) if PIPEWAIT weren't set. Ideally we'd throttle sending requests to libcurl without PIPEWAIT available, but perhaps it's best to get something working before we game that out? (I think adding that will be difficult) |
Doesn't |
@bors: r+ Aha right yes of course! |
📌 Commit 38fd476 has been approved by |
⌛ Testing commit 38fd476 with merge 8685531e5bf177bd63b36de92cac45e42c7f83d8... |
💔 Test failed - status-appveyor |
@bors: retry |
⌛ Testing commit 38fd476 with merge d6a4ab114d92d4fd9dfb080ed0b6dadcb319c4c5... |
💔 Test failed - status-appveyor |
@bors retry |
Fix fetching crates on old versions of libcurl. CURLOPT_PIPEWAIT was added in 7.43 but MacOS 10.9 has 7.30. Fixes #6155
☀️ Test successful - status-appveyor, status-travis |
CURLOPT_PIPEWAIT was added in 7.43 but MacOS 10.9 has 7.30.
Fixes #6155