Skip to content

Fix fetching crates on old versions of libcurl. #6383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Dec 6, 2018

CURLOPT_PIPEWAIT was added in 7.43 but MacOS 10.9 has 7.30.

Fixes #6155

@alexcrichton
Copy link
Member

Oh dear, good catch!

Currently though the performance of fetches does actually rely on PIPEWAIT because we issue all HTTP requests to libcurl simultaneously and it would otherwise flood crates.io with new TCP connections (one per crate) if PIPEWAIT weren't set.

Ideally we'd throttle sending requests to libcurl without PIPEWAIT available, but perhaps it's best to get something working before we game that out? (I think adding that will be difficult)

@ehuss
Copy link
Contributor Author

ehuss commented Dec 6, 2018

Doesn't set_max_host_connections handle that? I ran with debugging, and it only opens 2 connections.

@alexcrichton
Copy link
Member

@bors: r+

Aha right yes of course!

@bors
Copy link
Contributor

bors commented Dec 6, 2018

📌 Commit 38fd476 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Dec 6, 2018

⌛ Testing commit 38fd476 with merge 8685531e5bf177bd63b36de92cac45e42c7f83d8...

@bors
Copy link
Contributor

bors commented Dec 6, 2018

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Dec 6, 2018

⌛ Testing commit 38fd476 with merge d6a4ab114d92d4fd9dfb080ed0b6dadcb319c4c5...

@bors
Copy link
Contributor

bors commented Dec 6, 2018

💔 Test failed - status-appveyor

@ehuss
Copy link
Contributor Author

ehuss commented Dec 7, 2018

@bors retry

bors added a commit that referenced this pull request Dec 7, 2018
Fix fetching crates on old versions of libcurl.

CURLOPT_PIPEWAIT was added in 7.43 but MacOS 10.9 has 7.30.

Fixes #6155
@bors
Copy link
Contributor

bors commented Dec 7, 2018

⌛ Testing commit 38fd476 with merge 34610eb...

@bors
Copy link
Contributor

bors commented Dec 7, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 34610eb to master...

@bors bors merged commit 38fd476 into rust-lang:master Dec 7, 2018
@ehuss ehuss added this to the 1.33.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"error: [48] An unknown option was passed in to libcurl" on nightly only
3 participants