Skip to content

Improve error message when user cannot read credentials #7707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

debris
Copy link
Contributor

@debris debris commented Dec 13, 2019

Improve error message when user has no permission to read ~/.cargo/credentials

ref #7624

error message before:

error: Permission denied (os error 13)

now:

error: failed to read configuration file `/Users/marek/.cargo/credentials`

Caused by:
  Permission denied (os error 13)

@rust-highfive
Copy link

r? @ehuss

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 13, 2019
@ehuss
Copy link
Contributor

ehuss commented Dec 13, 2019

Thanks, can you add a test for that?

@ehuss
Copy link
Contributor

ehuss commented Dec 13, 2019

Hm, I'm also thinking this may not be necessary. This has all been rewritten in #7649, which consolidates file loading and takes care of this scenario.

@bors
Copy link
Contributor

bors commented Dec 19, 2019

☔ The latest upstream changes (presumably #7649) made this pull request unmergeable. Please resolve the merge conflicts.

@ehuss
Copy link
Contributor

ehuss commented Dec 19, 2019

Thanks again, it looks like this has been taken care of by #7649, so I'm going to close.

@ehuss ehuss closed this Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants