Skip to content

values: fix paragraph on memory address of an allocated object #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/values.rst
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ be stored in a memory location, and interpreted based on some :t:`type`.
An :dt:`allocated object` is a :t:`value` stored at some memory address.

:dp:`fls_kaomYy0Ml4Nh`
An :t:`[allocated object]s` :dt:`base address` is the the memory address the
object is stored.
The :dt:`base address` of an :t:`allocated object` is the memory address where the object is stored.
Copy link
Contributor

@traviscross traviscross May 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FLS is hard wrapped at 80 characters (for the most part). It seems worth being consistent with that until we decide to do otherwise.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for the most part)

It started at a 80 character hard wrap, but I was trying to push for breaking after sentence end instead some time after which is why its a bit mixed at the moment. Given the transfer now thats something to make a decision on probably (and then re-enforce that across the document).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the background. Probably we'd just unwrap paragraphs entirely then, as we decided to do in the Reference.


:dp:`fls_B5cmkWfD5GNt`
An :t:`[allocated object]s` :dt:`memory size` is the number of bytes the object
Expand Down