Extend compatibility to Stream and Sink #1162
Conversation
futures-util/src/sink/mod.rs
Outdated
| @@ -248,4 +254,14 @@ pub trait SinkExt: Sink { | |||
| { | |||
| Either::Right(self) | |||
| } | |||
|
|
|||
| /// Wraps a [`Sink`] into a sink compatible with libraries using | |||
| /// futures 0.1 `Sink`. Requires the `compat` feature to enable. | |||
|
Some lines are longer than 80 chars |
| /// Converts a futures 0.3 `TryFuture` into a futures 0.1 `Future` | ||
| /// and vice versa. | ||
| /// Converts a futures 0.3 `TryFuture`, `TryStream` or `Sink` into a futures 0.1 | ||
| /// `Future` and vice versa. |
There was a problem hiding this comment.
These should be links
There was a problem hiding this comment.
Ah never mind. Let's do the docs stuff in another PR
There was a problem hiding this comment.
Yeah, I started doing it then decided to just leave it for another pass.
|
Oh, are we using an 80 character limit? I just applied |
@Nemo157 That'd be great! |
Nemo157
force-pushed
the
extended-compat
branch
from
5527024 to
a5b7397
Compare
|
RE rustfmt: be aware that for |
|
I was only applying it to a couple of files so luckily didn’t hit that, did discover rust-lang/rustfmt#2887 on my next change though 😢 |
Sink is unidirectional because
Sink01::start_sendwas split intoSink03::poll_ready+Sink03::start_sendwhich makes tracking the context across the two method calls painful (might be possible with a customCompatstruct for this case, but I didn't investigate much).