Allow users to r- their own pull requests
#42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users want to be able to `r-` their own pull requests when they know the change will not successfully pass, and want to unapprove before they have time to push new code. Users can already effectively unapprove their own pull requests via other actions, like changing the target branch, pushing new commits, or closing and re-opening. So allowing them to `r-` instead of having to use a work-around should also be allowed. Fixes rust-lang#40
pietroalbini
approved these changes
May 30, 2019
|
Looks good to me |
|
Ok then, thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users want to be able to
r-their own pull requests when they know thechange will not successfully pass, and want to unapprove before they
have time to push new code.
Users can already effectively unapprove their own pull requests via
other actions, like changing the target branch, pushing new commits, or
closing and re-opening. So allowing them to
r-instead of having touse a work-around should also be allowed.
Fixes #40