Add dl_iterate_phdr to Android #2144
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Looks good, thanks :) |
|
📌 Commit 970fec9 has been approved by |
Add dl_iterate_phdr to Android Adds the `dl_iterate_phdr` function for Android targets. This is required for Android support in `gimli` and by proxy, `backtrace`. I tested this in [`backtrace`](https://crates.io/crates/backtrace) both in an i686 emulator and a physical arm64 device. This API is only available on Version 21+. I'm not sure how that's typically handled in `libc`, so I added a doc comment. Let me know what else is needed!
|
💔 Test failed - checks-actions |
Also, update tests to skip conflicts
|
@JohnTitor Thanks for the review! I figured out how to get the Android tests running locally and resolved a few places where naming didn't exactly match the header definitions. CI should be passing now. |
|
👍, @bors r+ |
|
📌 Commit ab1472e has been approved by |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
Adds the
dl_iterate_phdrfunction for Android targets. This is required for Android support ingimliand by proxy,backtrace.I tested this in
backtraceboth in an i686 emulator and a physical arm64 device.This API is only available on Version 21+. I'm not sure how that's typically handled in
libc, so I added a doc comment.Let me know what else is needed!