Skip to content

musl: fix test build with musl 1.2.0+ #4438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged

Conversation

xbjfk
Copy link
Contributor

@xbjfk xbjfk commented May 1, 2025

Description

Since musl 1.2.0, the utmpx.ut_session type changed from long to int (with padding). For now, skip the test for this field. This fixes #3305. This change type can probably be changed and this commit reverted when #3068 is merged.

Sources

diff
permalink

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see rust-lang/libc#3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot label +stable-nominated

Since musl 1.2.0, the utmpx.ut_session type changed from long to int
(with padding). For now, skip the test for this field.
Fixes: 3305
@rustbot rustbot added S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels May 1, 2025
@xbjfk xbjfk mentioned this pull request May 1, 2025
3 tasks
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@tgross35 tgross35 added this pull request to the merge queue May 1, 2025
Merged via the queue into rust-lang:main with commit 4cdbb5e May 1, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run tests in libc-test using musl (Alpine Linux 3.18.2)
3 participants