triagebot: Disable issue-links
#4444
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was enabled in order to encourage canonical links. Unfortunately it seems to also create warnings for crosslinking issues [1], which is something we definitely do want contributors to do (especially considering how commits get cherry picked around in this repo, there may not be a PR to easily refer to). Disable `issue-links` for now to avoid this. This also means we lose canonical link warnings, but there wasn't really any specific reason we needed that anyway. Cc: rust-lang/triagebot#1965 [1]: rust-lang#4443 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was enabled in order to encourage canonical links. Unfortunately it seems to also create warnings for crosslinking issues 1, which is something we definitely do want contributors to do (especially considering how commits get cherry picked around in this repo, there may not be a PR to easily refer to).
Disable
issue-linksfor now to avoid this. This also means we lose canonical link warnings, but there wasn't really any specific reason we needed that anyway.Cc: rust-lang/triagebot#1965