This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Replace calls to core::arch intrinsics with assembly
#534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some backends may replace calls to `core::arch` with multiple calls to `sqrt` [1], which becomes recursive. Help mitigate this by replacing the call with assembly. Results in the same assembly as the current implementation when built with optimizations. [1]: rust-lang/compiler-builtins#649
tgross35
added a commit
to tgross35/compiler-builtins
that referenced
this pull request
Apr 9, 2025
Includes [1] and [2], which should resolve problems cg_gcc has using scalar math operations as a fallback for vector operations. [1]: rust-lang/libm#459 [2]: rust-lang/libm#534
tgross35
added a commit
to rust-lang/compiler-builtins
that referenced
this pull request
Apr 9, 2025
Includes [1] and [2], which should resolve problems cg_gcc has using scalar math operations as a fallback for vector operations. [1]: rust-lang/libm#459 [2]: rust-lang/libm#534
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some backends may replace calls to
core::archwith multiple calls tosqrt1, which becomes recursive. Help mitigate this by replacing the call with assembly.Results in the same assembly as the current implementation when built with optimizations.