deny_unknown_fields in the configuration file #2572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid typos and make the config reading stricter.
ehuss
reviewed
Mar 6, 2025
src/config.rs
Outdated
Comment on lines
897
to
906
| #[test] | ||
| #[should_panic(expected = "Invalid configuration file")] | ||
| fn fail_on_invalid_config_field() { | ||
| let src = r#" | ||
| [book] | ||
| password = Secret | ||
| "#; | ||
|
|
||
| Config::from_str(src).unwrap(); | ||
| } |
There was a problem hiding this comment.
I don't think this test is actually checking the change in this PR. It seems to be checking that the TOML syntax is invalid.
|
Oh, right, I am still not used to the requirement of quotes in toml files. I'll now look into #1595 |
ehuss
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid typos and make the config reading stricter.
See #2493