Add pop-up window showing the keyboard shortcuts #2608
Conversation
|
Thanks! Would it be possible to update the styling for some of the dark themes? Right now it is unreadable there: 
Also, can you resolve the conflicts? |
|
How would a regular user know about the Looking at the code, it seems like the shortcut is only active when shift is being held. On custom keyboard layouts the user might not have to press shift to write |
|
I thought if this is accepted then I'd suggest to also add an icon to the menu to show a question mark. You are right about the shift. I'll have to check how to catch |
Make it display when the user presses `?`. Implements rust-lang#2607
Also handle the ? key with or without shift being pressed.
According to https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode the keyCode is deprecated (and removed). It is causing me some difficulty with the GUI tests because it can't differentiate between a slash and question mark correctly. Using keys seems to work.
This makes a few changes to the help popup: - Move css to chrome.css, since this is a UI element. - Move HTML code to index.hbs instead of generated in JavaScript. In general I prefer to keep HTML out of JavaScript when possible, and I didn't see a particular reason to avoid it. - Added a click handler to dismiss the popup. - Make sure handlers get removed when dismissed. - Use `mdbook-` prefixes for IDs to avoid collisions with headers. - Don't show search if it isn't enabled. - Add the new `/` shortcut. - Use flex layout for better positioning. - Dim out the surrounding text using an overlay. - Various other styling tweaks. - Add a GUI test.
Make it display when the user presses
?.Implements #2607