-
Notifications
You must be signed in to change notification settings - Fork 386
Provide a way to run a test that needs an external dependency #2443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I just ran into this yesterday, where I wanted to just run some files as a quick test, and the libc dependency became a problem. So it'd be great to have some sort of solution here. |
I'd prefer to run this via |
This should work for files outside of the test folder. It should also not compare the output to any stderr/stdout files, nor write any stderr/stdout files itself. It should ignore magic test comments. It should just run the file and not have any expectations about the exit code. Using |
This would also have been really useful to debug rust-lang/futures-rs#2669. Judging from oli-obk/ui_test#11 being closed, looks like this "just" needs some wiring up in Miri? |
Ah yes, I forgot about this one after implementing the ui_test side of things |
I won't get to this this year and January will most likely be spent catching up on other things. Will pick it up again after that. |
This works great, thanks! However printing the entire invocation makes this very verbose and makes it easy to miss the actual program output. Maybe this should be hidden, at least by default? |
We can just stop emitting that. I thought it may be practical if something goes wrong but I don't see a good way to hide it conditionally. We could make it a flag before the file name I guess? |
If something goes wrong I'd probably rather debug So yeah for now I'd vote for not emitting that. |
It would be pretty neat if we had a way to have
./miri run
work on tests that need external dependencies -- right now, these are a bit annoying to debug (and for tests that call into libc, this is a regression compared to the state before we added support for test dependencies). This should probably be a separate./miri run-dep
or so, and as much as possible it should share the test-dependencies infrastructure with ui_test/compiletest.The text was updated successfully, but these errors were encountered: