Add ./miri run-dep for running a file with test dependencies available
#2890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
May 11, 2023
RalfJung
reviewed
May 11, 2023
RalfJung
reviewed
May 11, 2023
RalfJung
reviewed
May 11, 2023
RalfJung
reviewed
May 11, 2023
RalfJung
reviewed
May 12, 2023
RalfJung
reviewed
May 12, 2023
RalfJung
reviewed
May 12, 2023
| config.program.args.push("--color".into()); | ||
| config.program.args.push("always".into()); | ||
| let mut cmd = ui_test::test_command(config, Path::new(&path))?; | ||
| cmd.arg("--"); |
There was a problem hiding this comment.
Who is this -- for? Separating cargo run arguments from arguments passed to the program?
There was a problem hiding this comment.
Yes, i'll add a comment
RalfJung
reviewed
May 12, 2023
tests/compiletest.rs
Outdated
| @@ -250,6 +266,19 @@ fn main() -> Result<()> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn run_dep_mode(target: String, mut args: impl Iterator<Item = OsString>) -> Result<()> { | |||
| let path = args.next().expect("./miri run-dep must be followed by a file name"); | |||
| let mut config = test_config(&target, "", Mode::Yolo, true); | |||
There was a problem hiding this comment.
Suggested change
| let mut config = test_config(&target, "", Mode::Yolo, true); | |
| let mut config = test_config(&target, "", Mode::Yolo, /* with_dependencies */ true); |
|
r=me with comments resolving the last 2 nits |
|
@bors r=RalfJung |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2443