Memleak #142
Merged
Memleak #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
reviewed
Feb 15, 2017
| //error-pattern: the evaluated program leaked memory | ||
|
|
||
| fn main() { | ||
| std::mem::forget(Box::new(42)); |
There was a problem hiding this comment.
Could you also add a test for an Rc cycle? There should be examples around back from before mem::forget was made safe, with the whole scoped threads discussion.
solson
reviewed
Feb 24, 2017
tests/run-pass/move_fn_closure.rs
Outdated
| @@ -0,0 +1,24 @@ | |||
| struct Foo<'a>(&'a mut bool); | |||
There was a problem hiding this comment.
You should probably merge this file with the existing https://github.com/solson/miri/blob/master/tests/run-pass/closure-drop.rs.
solson
reviewed
Feb 24, 2017
tests/run-pass/closure-drop.rs
Outdated
| @@ -26,5 +26,15 @@ fn main() { | |||
| f(g); | |||
There was a problem hiding this comment.
I meant removing the FIXME above this and simplifying it all. :P
There was a problem hiding this comment.
rustupped and fixed
instead of duplicating all the code from `write_value`, we forward to it.
erickt
pushed a commit
to erickt/miri
that referenced
this pull request
Feb 4, 2022
Expand drain to accept any RangeBounds<usize>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check for memory leaks after the interpretation is finished and error if any memory leaks occurred.
After fixing the bugs leading to leaks, no regressions were noticed in the rustc test suite.
fixes #135