Update MIR validation and test it #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt nightly" This reverts commit 791dbaf.
…orking around this
…icantly shrink our whitelist
…d whatever it calls
…t fullmir, if optimizations are disabled!
…lidation commands
…go test now passes :)
oli-obk
reviewed
Aug 4, 2017
| <std::heap::Heap as std::heap::Alloc>::|\ | ||
| <std::mem::ManuallyDrop<T>><std::heap::AllocErr>::new$|\ | ||
| <std::mem::ManuallyDrop<T> as std::ops::DerefMut><std::heap::AllocErr>::deref_mut$|\ | ||
| std::sync::atomic::AtomicBool::get_mut$|\ |
There was a problem hiding this comment.
Did some of these get lost?
There was a problem hiding this comment.
Not lost, but there are fewer exceptions now because I switched from -Zmir-emit-validate=2 (full validation everywhere) to -Zmir-emit-validate=1 (only limited validation in functions that have unsafe blocks).
|
lgtm after travis and one question. |
|
Right, travis of course fails because current nightly does not have the new statement yet. Not sure when exactly nightlies get built; if it is midnight UTC then that would be rather soon ;) |
|
Yay, Travis agrees that this all passes. :-))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the next nightly has rust-lang/rust#43403, this PR should make things compile again. :)