triagebot: enable [canonicalize-issue-links] and [no-mentions]
#4259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool |
|
This does not work the way I expected: it posted a long comment in #4277 saying we should change a bunch of links. That's not very useful, that PR is auto-generated based on rustc history and we can't change any part of it. |
|
I believe it's flagging every "Auto merge" and "Rollup merge" commits, we should either exclude those, or your "Automatic Rustup" PRs, any preference? As for flagging on external repo (rust-lang/rust here) it's currently a limitation since not all repos have the feature enable yet, I'm waiting on some feedback, like this one, to iron out some details before enabling it there. |
|
Ignoring the sync PRs makes most sense IMO, we already ignore them for the merge commit check. Only regular user PRs should be subject to these checks.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables two new triagebot feature
[canonicalize-issue-links]and[no-mentions].Documentation pending at rust-lang/rust-forge#825 and rust-lang/rust-forge#827.