internal: Show which roots are being scanned in progress messages #15636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
Sep 20, 2023
Veykril
added
S-waiting-on-author
|
PTAL? |
9999years
force-pushed
the
show-which-roots-are-scanned
branch
from
1717951 to
eb8bba5
Compare
|
☔ The latest upstream changes (presumably #16319) made this pull request unmergeable. Please resolve the merge conflicts. |
9999years
force-pushed
the
show-which-roots-are-scanned
branch
from
eb8bba5 to
1ceb2ea
Compare
|
Thanks! |
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
lnicola
changed the title
|
changelog internal (first contribution) show which roots are being scanned in progress messages |
This was referenced May 9, 2024
This was referenced May 28, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
Roots Scannedmessage to include the directory being scanned.Before:
Roots Scanned 206/210 (98%)After:
Roots Scanned 206/210: .direnv (98%)This makes it a lot easier to tell that
rust-analyzerisn't crashed, it's just trying to scan a huge directory.See: #12613