-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Use PGO on macOS x64 and arm64 builds #19611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zamazan4ik
commented
Apr 16, 2025
- related to Apply Profile-guided optimization to improve performance #9412 (comment)
You can test this by adding |
I guess it's easier to merge and revert if necessary. |
So, it doesn't work: https://github.com/rust-lang/rust-analyzer/actions/runs/14510906031/job/40709149737 As far as I understand, this due to that we use x86-64 macOS image instead of ARM image: https://github.com/actions/runner-images/blob/main/images/macos/macos-14-arm64-Readme.md . Are we allowed to use ARM macOS machines for RA? If yes, we can try to change the image and try once again. |
You can already test it in the nightly. |
Ha! I just saw someone link to https://www.youtube.com/watch?v=_EpALMNXM24. |
PGO world is not so big nowadays, yeah :D |
As I did previously in #19585 (comment) for Windows - now we test PGO vs non-PGO RA for macOS! Environment:
For benchmark purposes, I used Results (the
So we can conclude that PGO for RA works well for macOS platform too. I didn't test x86 macOS version (I am a bit lazy to run it under Rosetta2) but I expect exactly the same performance wins for that platform too. As far as I understand, RA in CI uses x86 macOS images to build x86 macOS RA version, so no PGO issues due to cross-compilation should appear. If anyone wants to test it and report the results back - it would be nice :) |