Skip to content

Make add_function generate functions in other modules via qualified path #3998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2020

Conversation

TimoFreiberg
Copy link
Contributor

@TimoFreiberg TimoFreiberg commented Apr 16, 2020

Additional feature for #3639

  • Add tests for paths with more segments
  • Make generating the function in another file work
  • Add pub or pub(crate) to the generated function if it's generated in a different module
  • Make the assist jump to the edited file
  • Enable file support in the check_assist helper

@TimoFreiberg TimoFreiberg force-pushed the add_function_with_path branch 2 times, most recently from 8107345 to 525a258 Compare April 18, 2020 14:36
@TimoFreiberg TimoFreiberg force-pushed the add_function_with_path branch 2 times, most recently from 9a09166 to 1b6b944 Compare April 20, 2020 21:37
@TimoFreiberg TimoFreiberg changed the title WIP: Make add_function generate functions in other modules via qualified path Make add_function generate functions in other modules via qualified path Apr 20, 2020
@TimoFreiberg TimoFreiberg force-pushed the add_function_with_path branch from 1b6b944 to 9d54747 Compare April 20, 2020 21:43
@TimoFreiberg TimoFreiberg force-pushed the add_function_with_path branch from 5693b85 to f2f882b Compare April 21, 2020 21:04
@matklad
Copy link
Member

matklad commented Apr 24, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 24, 2020

@bors bors bot merged commit 51a0058 into rust-lang:master Apr 24, 2020
@TimoFreiberg TimoFreiberg deleted the add_function_with_path branch April 25, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants