-
Notifications
You must be signed in to change notification settings - Fork 1.7k
NFA parser for mbe matcher #7513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
30ca5bc
to
18b7e21
Compare
9c7dee8
to
3e5b65b
Compare
Yeah, the regression is sizable, but it's not like we can not do it. I think some of it can be clawed back by just profiling and microoptimiaton. However, to do that, we really need a benchmark here. I ... now realize we don't have a great benchmarking story at all, but it's better to start somewhere. @edwin0cheng, could you do a separate PR which includes some bencmarks? I think they should be just usual With the benchmark in place, and with a good-first-issuer "optimize this", I'll be more than comfortable to merge this. |
3e5b65b
to
e44901e
Compare
Rebased from #7566 and here is the benchmark result :
2x slower :( |
9d8af91
to
2473256
Compare
2473256
to
cff2201
Compare
bors r+ Could you create an issue with mentoring instructions on how to run the benchmark? I wonder if we can nerd-snipe someone to look at the code with a profiler... |
|
Almost straight porting from rustc one, but a little bit slow :(
From:
To:
Fixes #4777