Skip to content

feat: go to implementation on trait functions #8988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2021

Conversation

lf-
Copy link
Contributor

@lf- lf- commented May 25, 2021

Fix #8537.

GIF:
output

@matklad
Copy link
Member

matklad commented May 25, 2021

bors r+

bors bot added a commit that referenced this pull request May 25, 2021
8988: feat: go to implementation on trait functions r=matklad a=lf-

Fix #8537.

GIF:
![output](https://user-images.githubusercontent.com/6652840/119501981-45a45c00-bd1e-11eb-8336-9145f2888643.gif)

Co-authored-by: Jade <[email protected]>
@bors
Copy link
Contributor

bors bot commented May 25, 2021

Build failed:

@lnicola
Copy link
Member

lnicola commented May 25, 2021

bors retry

@lnicola
Copy link
Member

lnicola commented May 25, 2021

CC actions/runner-images#3418

@bors
Copy link
Contributor

bors bot commented May 25, 2021

@bors bors bot merged commit f3cfd8a into rust-lang:master May 25, 2021
lf- added a commit to lf-/rust-analyzer that referenced this pull request May 25, 2021
I forgot to put this into rust-lang#8988, sorry.

Goto implementation on a const on the trait will go to the
implementations with their respective definitions of the const, if
present.
bors bot added a commit that referenced this pull request May 25, 2021
8990: feat: Also do goto implementation on assoc consts r=lnicola a=lf-

I forgot to put this into #8988, sorry.

Goto implementation on a const on the trait will go to the
implementations with their respective definitions of the const, if
present.

Co-authored-by: Jade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go to implementations should work on trait functions.
3 participants