chore: fix last clippy lints and enforce in CI #3106
Merged
+60
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
changed the title
nyurik
changed the title
nyurik
changed the title
nyurik
force-pushed
the
lints
branch
2 times, most recently
from
b07c1ce to
005a5de
Compare
emilio
approved these changes
Apr 10, 2025
| uses: dtolnay/rust-toolchain@master | ||
| with: | ||
| # TODO: Should ideally be stable, but we use some nightly-only | ||
| # features. |
There was a problem hiding this comment.
This TODO is still accurate afaict, let's keep it?
There was a problem hiding this comment.
Ah I had this written before and somehow didn't submit. Nevermind tho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, I think we should remove installation of the stable rust - github runners have been very good at keeping rust version up to date, no need to waste time for each job to install it.