ci: use stable again moving forward Rust for Linux job #3189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v6.14 is the latest tag and it contains v6.14-rc2 which included the
fix for the `soft-float` error (commit 6273a058383e ("x86: rust: set
rustc-abi=x86-softfloat on rustc>=1.86.0") in Linux).
Signed-off-by: Miguel Ojeda <[email protected]>
Now that the Rust for Linux job is moved forward to v6.14, we can use Rust 1.86.0, i.e. the current stable, again. Thus revert the previous change. Signed-off-by: Miguel Ojeda <[email protected]>
32 tasks
emilio
approved these changes
Apr 4, 2025
| @@ -96,7 +96,7 @@ if [ "$BINDGEN_RUST_FOR_LINUX_TEST" == "1" ]; then | |||
| # and each update should only contain this change. | |||
| # | |||
| # Both commit hashes and tags are supported. | |||
| LINUX_VERSION=v6.14-rc1 | |||
| LINUX_VERSION=v6.14 | |||
There was a problem hiding this comment.
Gah, so I was off by a RC then ;)
There was a problem hiding this comment.
Yeah, that was very bad luck... :)
| @@ -125,13 +125,13 @@ CONFIG_KUNIT=y | |||
| CONFIG_RUST_KERNEL_DOCTESTS=y | |||
| EOF | |||
|
|
|||
| make -C linux KBUILD_VERBOSE=1 LLVM=1 -j$(($(nproc) + 1)) \ | |||
| make -C linux LLVM=1 -j$(($(nproc) + 1)) \ | |||
There was a problem hiding this comment.
I think this might still be useful but either way. Yeah maybe it's too verbose.
There was a problem hiding this comment.
Yeah, I wasn't sure if you intended to keep it or it was just for debugging the issue, so I left the tree as it was before this happened.
It is fairly verbose, yeah; on the other hand, we build a tiny part of the kernel, so it should be OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Fixes: #3188