Skip to content

Do not bless by default in ui tests #11333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

Alexendoo
Copy link
Member

This restores the default behaviour to check the .stderr, it was changed in #11239 to bless by default in cargo test (unless in github actions), but check by default in cargo uitest which is fairly confusing

It also meant cargo uitest -F internal no longer worked

--bless prevents the use of Args::test but we can look at reintegrating with that after @oli-obk's vacation

r? @flip1995

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 13, 2023
@flip1995
Copy link
Member

@bors r+

Thanks! I also was surprised by the bless-by-default change, but didn't want to block the bitrotty PR on that. Agreed that the check-by-default behavior feels more natural.

@bors
Copy link
Contributor

bors commented Aug 13, 2023

📌 Commit 3ac06a1 has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 13, 2023

⌛ Testing commit 3ac06a1 with merge 83afad4...

@bors
Copy link
Contributor

bors commented Aug 13, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 83afad4 to master...

@bors bors merged commit 83afad4 into rust-lang:master Aug 13, 2023
@Alexendoo Alexendoo deleted the uitest-default-check branch August 13, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants