Fix ICE in upper_case_acronyms
#12903
Conversation
rustbot
added
the
S-waiting-on-review
Jarcho
changed the title
upper_case_acronyms and remove most of the string alloc…upper_case_acronyms
| for c in s.chars() { | ||
| if c.is_ascii_uppercase() { | ||
| count += 1; | ||
| if count == 3 { |
There was a problem hiding this comment.
Why do we check for 3 here (but then 2 in the tail expression)? Doesn't this mean that we won't warn on AB3 or ABc?
The documentation makes it sound like that we want to emit a warning there
Triggers if there is more than one uppercase char next to each other
There was a problem hiding this comment.
Hmm, the old logic doesn't really seem to follow that very strictly either. The old logic does catch AB3 but not ABc
There was a problem hiding this comment.
Because something like AFoo shouldn't lint, but AS should. It really shouldn't check the case for the third letter, but the old logic didn't handle that properly either.
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
fixes #12284
The logic has been rewritten to avoid allocations. The old version allocated multiple vecs and strings for each identifier. The new logic allocates a single string only when the lint triggers.
This also no longer lints on strings which don't start with an uppercase letter (e.g.
something_FOO).changelog: none