Fix needless_doctest_main
panic when doctest is invalid
#15052
Merged
+20
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8244
Closes #15041
This feels like a bug with the compiler, because the panic happens when
Diag
is getting unwinded. However,drop()
is already called in.cancel()
so this should not happen.In this PR, I find a workaround to just call
emit()
, since theDiagCtxt
here is just aio::sink
, nothing will happen and the panic just goes away.changelog: [
needless_doctest_main
] fix panic when doctest is invalid