Fix #2293 - ptr_arg #3131
Merged
Fix #2293 - ptr_arg #3131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess in that case the issue is fixed by your regression test. We don't really need to care about triggering lints inside the standard library if those lints are specifically about standard library types. |
|
Thanks! |
|
Hi! Could you leave the requested comment in #3230 for relicensing? |
|
@Manishearth Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I am new to the clippy codebase and I was hoping to help by fixing #2293.
I've added a test case to the test file for
ptr_arg, which I believe matches what the original issue said to do to recreate the bug, but runningTESTNAME=ui/ptr_arg cargo test --test compile-testafter making this change did not cause a test failure. I would have expected the tests to fail here, because the issue description said that clippy would incorrectly warn in this situation.Am I missing something? Or perhaps was this issue resolved with some other change?