fixes #3151 by skipping the lint instead of crashing #3152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
reviewed
Sep 9, 2018
clippy_lints/src/types.rs
Outdated
| .and_then(|snip| Some(item.span.lo() + BytePos(snip.find("impl")? as u32 + 4))); | ||
| if let Some(pos) = pos { | ||
| Span::new(pos, pos, item.span.data().ctxt) | ||
| }else{ |
There was a problem hiding this comment.
Can you add some spaces here?
There was a problem hiding this comment.
ok, done. cargo fmt didn't change this, maybe we should adjust rustfmt.toml?
There was a problem hiding this comment.
weird, not sure why it wouldn't pick up on that.
|
Hi! Could you leave the requested comment in #3230 for relicensing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.