Fix single_match suggestions with expanded macros #3272
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansch
force-pushed
the
fix_single_match_suggestion_with_macro
branch
3 times, most recently
from
685bb33 to
7ee81ae
Compare
phansch
added
the
S-waiting-on-review
flip1995
reviewed
Oct 15, 2018
clippy_lints/src/matches.rs
Outdated
| let els_str = els.map_or(String::new(), |els| format!(" else {}", expr_block(cx, els, None, ".."))); | ||
| let els_str = els.map_or(String::new(), |els| { | ||
| if in_macro(els.span) { | ||
| " else { .. }".to_string() |
There was a problem hiding this comment.
Could we maybe get a better suggestion with source_callsite()
Everything else LGTM.
There was a problem hiding this comment.
I will give it a try, thanks!
phansch
added
S-waiting-on-author
phansch
force-pushed
the
fix_single_match_suggestion_with_macro
branch
from
7ee81ae to
dfe08fb
Compare
|
Rebased onto master and added dfe08fb to include macro callsites in the suggestions. |
|
|
phansch
added
S-blocked
|
Closing in favor of #3366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
single_matchwas expanding macros in the suggested if and else expressions. This fix checks if the suggested span is inside a macro.As far as I can tell this..
Fixes #1148
Fixes #2455