Skip to content

Add common lint tools doc #5641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2020
Merged

Add common lint tools doc #5641

merged 1 commit into from
May 25, 2020

Conversation

ThibsG
Copy link
Contributor

@ThibsG ThibsG commented May 24, 2020

This PR starts adding some documentation about linting tools.

Retrieving all methods of a type is not covered at this time.

fixes partially: #3843

changelog: none

@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 24, 2020
flip1995
flip1995 reviewed May 25, 2020
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great! I would suggest to rename this to "Common tools for writing lints", since the name "lint tools" already exists in the rust ecosystem and refers to tools providing lints, like Clippy.

@flip1995 flip1995 added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels May 25, 2020
@flip1995 flip1995 self-assigned this May 25, 2020
@ThibsG ThibsG force-pushed the DocCommonTools branch 2 times, most recently from c082443 to 8f147f8 Compare May 25, 2020 17:59
flip1995
flip1995 approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a 120 characters line length limit. Otherwise this LGTM.

@ThibsG
Copy link
Contributor Author

ThibsG commented May 25, 2020

We have a 120 characters line length limit. Otherwise this LGTM.

👍 just saw it

@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 25, 2020

📌 Commit 8270412 has been approved by flip1995

@bors
Copy link
Contributor

bors commented May 25, 2020

⌛ Testing commit 8270412 with merge acd484e...

@bors
Copy link
Contributor

bors commented May 25, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing acd484e to master...

@bors bors merged commit acd484e into rust-lang:master May 25, 2020
@ThibsG ThibsG deleted the DocCommonTools branch May 26, 2020 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees

@flip1995 flip1995

Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThibsG @flip1995 @bors @phansch