Skip to content

README: sort en/disabling section, fix typos, add note #6173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

Lotterleben
Copy link
Contributor

it took me a while to figure out why cargo clippy -- -Aclippy::pedantic -Wclippy::items-after-statements still showed me all the lints. At first I thought it was due to the missing spaces in the current example and I debugged that until I stumbled across an issue noting that you have to touch a random file or run cargo clean when you're running clippy repeatedly on an unchanged codebase. This PR is an attempt to save the next person some time and also structure the "Allowing/denying lints" section a bit more while we're at it.


Please keep the line below
changelog: none

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ebroto (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 14, 2020
@ebroto
Copy link
Member

ebroto commented Oct 15, 2020

Thanks for your contribution!

FYI this happens because cargo does not know that flags passed to Clippy have changed. I think I may have a solution to this (discussed in #5214), so I hope I can revert the note you added soon :)

@bors r+

@bors
Copy link
Contributor

bors commented Oct 15, 2020

📌 Commit 8ba18ae has been approved by ebroto

@bors
Copy link
Contributor

bors commented Oct 15, 2020

⌛ Testing commit 8ba18ae with merge 0cba5e6...

@bors
Copy link
Contributor

bors commented Oct 15, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: ebroto
Pushing 0cba5e6 to master...

@bors bors merged commit 0cba5e6 into rust-lang:master Oct 15, 2020
@Lotterleben Lotterleben deleted the docs-typo branch October 16, 2020 08:43
@Lotterleben
Copy link
Contributor Author

Yay! Thanks for the hint, I'll keep an eye on 5214 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants