-
Notifications
You must be signed in to change notification settings - Fork 1.7k
WIP: PR to test #7298 #7401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: PR to test #7298 #7401
Conversation
This now no longer uses the python script to generate the documentation, but uses the output of the monster.
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
Whoops forgot the @ before ghost... |
I just realized, that I almost made a big whoopsie, because I didn't stop checking out the old deploy script, which would've pushed something to gh-pages, if there were changes. |
Hmmm, I'm inclined to break stable deploy for one cycle. This checking out of the master deploy script really helped in the past, but now it is a bit of a PITA. I would like to keep doing this, since it helps usually more than it hurts. With the next release, the deployment on stable will break, since it still has to run the python script to create the documentation. This will require a fix by hand. But I rather do this, than copying the deploy script for a whole release cycle, and then spend another release cycle to remove the copy again. Beta shouldn't be affected by this, since it will receive the new doc generation before the deploy job is run. |
Explain why we need to checkout deploy files from master
Debug build: 2 min clean build; 50 seconds cached build Release build: 5 min clean build; Always does a clean build... |
eb0f705
to
1a71786
Compare
r? ghost
nothing to see here, just testing #7298