Skip to content

WIP: PR to test #7298 #7401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

WIP: PR to test #7298 #7401

wants to merge 9 commits into from

Conversation

flip1995
Copy link
Member

r? ghost

nothing to see here, just testing #7298

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 25, 2021
@flip1995 flip1995 removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 25, 2021
@flip1995
Copy link
Member Author

Whoops forgot the @ before ghost...

@flip1995
Copy link
Member Author

I just realized, that I almost made a big whoopsie, because I didn't stop checking out the old deploy script, which would've pushed something to gh-pages, if there were changes.

@flip1995
Copy link
Member Author

Hmmm, I'm inclined to break stable deploy for one cycle. This checking out of the master deploy script really helped in the past, but now it is a bit of a PITA. I would like to keep doing this, since it helps usually more than it hurts.

With the next release, the deployment on stable will break, since it still has to run the python script to create the documentation. This will require a fix by hand. But I rather do this, than copying the deploy script for a whole release cycle, and then spend another release cycle to remove the copy again.

Beta shouldn't be affected by this, since it will receive the new doc generation before the deploy job is run.

flip1995 added 2 commits June 25, 2021 18:30
Explain why we need to checkout deploy files from master
@flip1995
Copy link
Member Author

Debug build: 2 min clean build; 50 seconds cached build

Release build: 5 min clean build; Always does a clean build...

@flip1995 flip1995 force-pushed the ci-switch-to-monster branch from eb0f705 to 1a71786 Compare June 25, 2021 16:53
@flip1995 flip1995 closed this Jun 25, 2021
@flip1995 flip1995 deleted the ci-switch-to-monster branch July 29, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants