Fixes [trait_duplication_in_bounds] false positives
#9167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Assigning this to me, since I reviewed the last PR. I pormise that it won't take me 2 months this time! r? @flip1995 |
flip1995
reviewed
Jul 19, 2022
flip1995
added
S-waiting-on-author
- only compare where predicates to trait bounds when generating where clause specific message to fix rust-lang#9151 - use comparable_trait_ref to account for trait bound generics to fix rust-lang#8757
aldhsu
force-pushed
the
fix-trait-duplication-false-pos
branch
from
7f2797a to
3ddc04f
Compare
flip1995
added
S-waiting-on-review
|
Thanks! This was the only thing for now. The comments added are great! I now have to go through the tests, but I don't expect that there's anything left for you to do 👍 |
aldhsu
force-pushed
the
fix-trait-duplication-false-pos
branch
from
0cf2864 to
3ddc04f
Compare
flip1995
approved these changes
Aug 14, 2022
|
Maybe in another PR :D @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9076 #9151 #8757.
Partially fixes #8771.
changelog: [
trait_duplication_in_bounds]: Reduce number of false positives.