Skip to content

simplify mut_mut lint #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2016
Merged

simplify mut_mut lint #940

merged 1 commit into from
May 25, 2016

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented May 17, 2016

No description provided.

@mcarton
Copy link
Member

mcarton commented May 17, 2016

Looks like we need to rustup. I could do that later today.

@mcarton
Copy link
Member

mcarton commented May 17, 2016 •
edited
Loading

Does this fix #939? If so you should add it to the tests.

@oli-obk
Copy link
Contributor Author

oli-obk commented May 17, 2016

no, it doesn't change anything, it's just a refactoring, because I couldn't grok it due to the various functions and map calls

@oli-obk
Copy link
Contributor Author

oli-obk commented May 17, 2016

rustup done. This removed some code explicitly written for self from the lifetime checks. HIR is great!

@oli-obk oli-obk changed the title simplify mut_mut lint rustup + simplify mut_mut lint May 17, 2016
@mcarton mcarton mentioned this pull request May 17, 2016
Merged
@mcarton
Copy link
Member

mcarton commented May 17, 2016

@oli-obk sorry, I did not notice that you had rustuped in this PR and did it in #942, there is now merge conflicts.

@oli-obk
Copy link
Contributor Author

oli-obk commented May 18, 2016

rebased

@oli-obk oli-obk changed the title rustup + simplify mut_mut lint simplify mut_mut lint May 18, 2016
@oli-obk
Copy link
Contributor Author

oli-obk commented May 25, 2016

rebased

@mcarton mcarton merged commit 77ed899 into rust-lang:master May 25, 2016
@oli-obk oli-obk deleted the simplify/mut_mut branch May 27, 2016 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oli-obk @mcarton