Code

Update Clippy#114729

Code

Merged

bors merged 79 commits intorust-lang:masterrust-lang/rust:masterfrom

flip1995:clippyupflip1995/rust:clippyupCopy head branch name to clipboard

Aug 11, 2023

Commits

Commits on Jul 13, 2023

• Rename cast_ref_to_mut to invalid_reference_casting (clippy side)

  Urgau

  committed
  50da775

  Copy full SHA for 50da775

Commits on Jul 19, 2023

• redundant_type_annotations: only pass certain def kinds to type_of

  Alexendoo

  committed
  d4f735c

  Copy full SHA for d4f735c

Commits on Jul 23, 2023

• fix

  fee1-dead

  committed
  1662fdb

  Copy full SHA for 1662fdb

Commits on Jul 24, 2023

• Perform OpaqueCast field projection on HIR, too.

  Show description for d94d85f
  oli-obk

  committed
  d94d85f

  Copy full SHA for d94d85f

Commits on Jul 27, 2023

• Remove `constness` from `ParamEnv`

  fee1-dead

  committed
  be0b4d5

  Copy full SHA for be0b4d5

• bless clippy

  fee1-dead

  committed
  39fb315

  Copy full SHA for 39fb315

Commits on Jul 28, 2023

• Auto merge of #114134 - fee1-dead-contrib:rm-constness-from-param-env, r=oli-obk

  Show description for e97a770
  bors

  committed
  e97a770

  Copy full SHA for e97a770

• Make Clippy understand generic const items

  fmease

  committed
  4c9d68e

  Copy full SHA for 4c9d68e

Commits on Jul 29, 2023

• Auto merge of #111916 - fee1-dead-contrib:noop-method-call-warn, r=compiler-errors

  Show description for 0c0026e
  bors

  committed
  0c0026e

  Copy full SHA for 0c0026e

• Auto merge of #113422 - Urgau:cast_ref_to_mut-pre-beta, r=Nilstrieb

  Show description for 436060f
  bors

  committed
  436060f

  Copy full SHA for 436060f

Commits on Jul 30, 2023

• Mark `map_or` as `#[must_use]`

  WaffleLapkin

  committed
  0c93e30

  Copy full SHA for 0c93e30

• Rollup merge of #112655 - WaffleLapkin:must_use_map_or, r=workingjubilee

  Show description for f54263a
  matthiaskrgr

  authored
  f54263a

  Copy full SHA for f54263a

Commits on Jul 31, 2023

• Use builder pattern instead of lots of arguments for `EmitterWriter::new`

  oli-obk

  committed
  9a0af82

  Copy full SHA for 9a0af82

• Remove a `bool` for color in favor of the `WriteColor` trait wrapping colored and uncolored printing

  oli-obk

  committed
  084c90a

  Copy full SHA for 084c90a

• [`unnecessary_mut_passed`]: don't lint in macro expansions

  y21

  committed
  dc1e8b0

  Copy full SHA for dc1e8b0

• New lint `ignored_unit_patterns`

  samueltardieu

  committed
  f9a6dfa

  Copy full SHA for f9a6dfa

• Merge commit '5436dba826191964ac1d0dab534b7eb6d4c878f6' into clippyup

  flip1995

  committed
  b0e64a9

  Copy full SHA for b0e64a9

Commits on Aug 1, 2023

• Auto merge of #11269 - y21:issue11268, r=Centri3

  Show description for 588c1ab
  bors

  committed
  588c1ab

  Copy full SHA for 588c1ab

• Rename incorrect_fn_null_checks to useless_ptr_null_checks (clippy side)

  Urgau

  committed
  7ef1a54

  Copy full SHA for 7ef1a54

Commits on Aug 2, 2023

• fix RedundantLocals clippy caused by async and await

  chenyukang

  committed
  0ff6579

  Copy full SHA for 0ff6579

• Alphabetically order arms in methods/mod.rs match

  

  Your Name

  committed
  72074a0

  Copy full SHA for 72074a0

• Auto merge of #11284 - lengyijun:reorder, r=blyxyas

  Show description for 78f5e0d
  bors

  committed
  78f5e0d

  Copy full SHA for 78f5e0d

• Remove constness from `TraitPredicate`

  fee1-dead

  committed
  b07de24

  Copy full SHA for b07de24

• Do not lint unwrapping on `!` or never-like enums

  Centri3

  committed
  779e0f4

  Copy full SHA for 779e0f4

• Extract never-like into `clippy_utils`

  Centri3

  committed
  71c5413

  Copy full SHA for 71c5413

• Auto merge of #11252 - Centri3:#11245, r=xFrednet

  Show description for 7af5ea1
  bors

  committed
  7af5ea1

  Copy full SHA for 7af5ea1

• Suppress `question_mark` if `question_mark_used` is not allowed

  Centri3

  committed
  4d49065

  Copy full SHA for 4d49065

• Auto merge of #11286 - Centri3:#11283, r=Alexendoo

  Show description for 97d1cfa
  bors

  committed
  97d1cfa

  Copy full SHA for 97d1cfa

• Take snippet instead of pretty printing type

  Centri3

  committed
  fef85c9

  Copy full SHA for fef85c9

• Auto merge of #11288 - Centri3:#11278, r=Alexendoo

  Show description for 237dd59
  bors

  committed
  237dd59

  Copy full SHA for 237dd59

• Auto merge of #107254 - chenyukang:yukang/fix-107113-wrong-sugg-in-macro, r=estebank

  Show description for ff27f90
  bors

  committed
  ff27f90

  Copy full SHA for ff27f90

Commits on Aug 3, 2023

• Auto merge of #11242 - samueltardieu:issue-11238, r=Centri3,giraffate

  Show description for 1eb254e
  bors

  committed
  1eb254e

  Copy full SHA for 1eb254e

• Add `internal_features` lint

  Show description for 85b5e98
  Noratrieb

  committed
  85b5e98

  Copy full SHA for 85b5e98

• Rollup merge of #113657 - Urgau:expand-incorrect_fn_null_check-lint, r=cjgillot

  Show description for 8f4f476
  matthiaskrgr

  authored
  8f4f476

  Copy full SHA for 8f4f476

• Fix `suspicious_xor_used_as_pow.rs` performance

  blyxyas

  committed
  3fb8441

  Copy full SHA for 3fb8441

• Auto merge of #11255 - blyxyas:fix-perf-sus_xor_used_as_pow, r=xFrednet

  Show description for 5818225
  bors

  committed
  5818225

  Copy full SHA for 5818225

• Auto merge of #108955 - Nilstrieb:dont-use-me-pls, r=oli-obk

  Show description for d412b91
  bors

  committed
  d412b91

  Copy full SHA for d412b91

Commits on Aug 4, 2023

• Rollup merge of #114022 - oli-obk:tait_ice_alias_field_projection, r=cjgillot

  Show description for 1589759
  matthiaskrgr

  authored
  1589759

  Copy full SHA for 1589759

• Improve spans for indexing expressions

  Show description for ed0dfed
  Noratrieb

  committed
  ed0dfed

  Copy full SHA for ed0dfed

• Auto merge of #114104 - oli-obk:syn2, r=compiler-errors

  Show description for 1852200
  bors

  committed
  1852200

  Copy full SHA for 1852200

• Rollup merge of #114434 - Nilstrieb:indexing-spans, r=est31

  Show description for 878a87d
  matthiaskrgr

  authored
  878a87d

  Copy full SHA for 878a87d

• Auto merge of #114481 - matthiaskrgr:rollup-58pczpl, r=matthiaskrgr

  Show description for ec1d61e
  bors

  committed
  ec1d61e

  Copy full SHA for ec1d61e

Commits on Aug 5, 2023

• Small code style adjustments

  lengyijun

  committed
  e5b0483

  Copy full SHA for e5b0483

• fix: Make ConstEvalLateContext::new() public, to match the 'constant_context()' function that it replaced

  MortenLohne

  committed
  ab1281f

  Copy full SHA for ab1281f

• New lints: `impossible_double_const_comparisons` and `ineffective_double_const_comparisons`

  MortenLohne

  committed
  046d3df

  Copy full SHA for 046d3df

• Add descriptions for 'impossible_double_const_comparisons' and 'ineffective_double_const_comparisons'

  MortenLohne

  committed
  e16a2ac

  Copy full SHA for e16a2ac

• Add missing variable decl to doc comment

  MortenLohne

  committed
  08e1333

  Copy full SHA for 08e1333

• Add tests for const comparisons that compare two different types

  MortenLohne

  committed
  8f40d09

  Copy full SHA for 8f40d09

• Optimize by doing a cheap check for double binary expression first

  MortenLohne

  committed
  b5ef66f

  Copy full SHA for b5ef66f

• Rename 'impossible_double_const_comparisons' -> 'impossible_comparisons' and 'ineffective_double_const_comparisons' -> 'redundant_comparisons', after discussion on Zulip

  MortenLohne

  committed
  1d61fc1

  Copy full SHA for 1d61fc1

Commits on Aug 6, 2023

• Add lifetime parameter to 'Constant', after rebasing on upstream

  MortenLohne

  committed
  9646446

  Copy full SHA for 9646446

• Replace ConstEvalLateContext::new() with two calls to constant() to simplify the code, after PR suggestion

  MortenLohne

  committed
  0e064d5

  Copy full SHA for 0e064d5

• Provide fallback code snippets, if the snippet is not available

  MortenLohne

  committed
  3157b96

  Copy full SHA for 3157b96

• cleanup misinformation regarding has_deref

  ouz-a

  committed
  44cd3bc

  Copy full SHA for 44cd3bc

• Rollup merge of #114505 - ouz-a:cleanup_mir, r=RalfJung

  Show description for 261837c
  matthiaskrgr

  authored
  261837c

  Copy full SHA for 261837c

• Update clippy_lints/src/operators/mod.rs

  Show description for d628046
  

  Manishearth

  and

  Centri3

  authored
  d628046

  Copy full SHA for d628046

• Auto merge of #10843 - MortenLohne:feat/double-const-comparisons, r=Centri3

  Show description for 6a2c8a1
  bors

  committed
  6a2c8a1

  Copy full SHA for 6a2c8a1

• Auto merge of #11191 - Alexendoo:redundant-type-annotations-ice, r=llogiq

  Show description for 526d115
  bors

  committed
  526d115

  Copy full SHA for 526d115

Commits on Aug 7, 2023

• Auto merge of #11295 - lengyijun:typo, r=Centri3

  Show description for 84d2896
  bors

  committed
  84d2896

  Copy full SHA for 84d2896

• Store the laziness of type aliases in the DefKind

  fmease

  committed
  3ff6fd2

  Copy full SHA for 3ff6fd2

Commits on Aug 8, 2023

• Rollup merge of #114566 - fmease:type-alias-laziness-is-crate-specific, r=oli-obk

  Show description for 5f86009
  matthiaskrgr

  authored
  5f86009

  Copy full SHA for 5f86009

• [`redundant_guards`]: don't lint on floats

  y21

  committed
  f959ccc

  Copy full SHA for f959ccc

• document the new behavior and add test for float in struct

  y21

  committed
  b615650

  Copy full SHA for b615650

• Auto merge of #11305 - y21:issue11304, r=Centri3

  Show description for 7c595b4
  bors

  committed
  7c595b4

  Copy full SHA for 7c595b4

Commits on Aug 9, 2023

• clarify why `Vec::new()` + resize is worse than `vec![0; N]`

  y21

  committed
  830bac5

  Copy full SHA for 830bac5

• Reword paragraph

  Show description for d2acfb3
  

  y21

  and

  djc

  authored
  d2acfb3

  Copy full SHA for d2acfb3

• Remove unnecessary paragraph, move examples

  y21

  committed
  dd25cc3

  Copy full SHA for dd25cc3

• Auto merge of #11310 - y21:slow_vector_initialization_doc, r=xFrednet,djc

  Show description for add2722
  bors

  committed
  add2722

  Copy full SHA for add2722

Commits on Aug 10, 2023

• Merge remote-tracking branch 'upstream/master' into rustup

  flip1995

  committed
  17b9c42

  Copy full SHA for 17b9c42

• Bump nightly version -> 2023-08-10

  flip1995

  committed
  61e9b15

  Copy full SHA for 61e9b15

• Don't ICE with late bound regions

  Centri3

  committed
  beb57f0

  Copy full SHA for beb57f0

• Add test for `&mut`

  Centri3

  committed
  7b2fd81

  Copy full SHA for 7b2fd81

Commits on Aug 11, 2023

• Auto merge of #11318 - Centri3:#11309, r=Manishearth

  Show description for bd1554c
  bors

  committed
  bd1554c

  Copy full SHA for bd1554c

• redundant_locals: fix FPs on mutated shadows

  Show description for a5f62bd
  max-niederman

  committed
  a5f62bd

  Copy full SHA for a5f62bd

• Fix redundant_locals for Async desugaring

  flip1995

  committed
  0fc051d

  Copy full SHA for 0fc051d

• Dogfood and bless tests

  flip1995

  committed
  3927677

  Copy full SHA for 3927677

• Auto merge of #11316 - flip1995:rustup, r=flip1995

  Show description for 8703661
  bors

  committed
  8703661

  Copy full SHA for 8703661

• Auto merge of #11320 - max-niederman:redundant_locals_shadow_mutated, r=Alexendoo

  Show description for 1e8fdf4
  bors

  committed
  1e8fdf4

  Copy full SHA for 1e8fdf4

• Merge commit '1e8fdf492808a25d78a97e1242b835ace9924e4d' into clippyup

  flip1995

  committed
  852bf4e

  Copy full SHA for 852bf4e