-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Enable stack probes on aarch64 for LLVM 18 #118491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
use crate::spec::base::apple::{ios_llvm_target, opts, Arch}; | ||
use crate::spec::{FramePointer, SanitizerSet, Target, TargetOptions}; | ||
use crate::spec::{FramePointer, SanitizerSet, StackProbeType, Target, TargetOptions}; | ||
|
||
pub fn target() -> Target { | ||
let arch = Arch::Arm64; | ||
|
@@ -18,6 +18,7 @@ pub fn target() -> Target { | |
options: TargetOptions { | ||
features: "+neon,+fp-armv8,+apple-a7".into(), | ||
max_atomic_width: Some(128), | ||
stack_probes: StackProbeType::Inline, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need to gate use of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's ignored -- or rather goes unchecked and unnoticed. The other times we've concerned ourselves about the version is when we know there are bugs in the implementation. |
||
frame_pointer: FramePointer::NonLeaf, | ||
..base | ||
}, | ||
|
Uh oh!
There was an error while loading. Please reload this page.