Add f16 formatting and parsing
#127013
Open
Add f16 formatting and parsing
#127013
+659
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
@rustbot label +rla-silenced |
rustbot
added
the
rla-silenced
|
@rustbot label +F-f16_and_f128 |
|
This will need #127510 |
|
☔ The latest upstream changes (presumably #127020) made this pull request unmergeable. Please resolve the merge conflicts. |
fbstj
reviewed
Jul 15, 2024
90 tasks
tgross35
force-pushed
the
f16-format-parse
branch
2 times, most recently
from
7c3f9c1 to
f3ebeb3
Compare
|
Update: I'm really just waiting on #128083 to bump stage0, managing |
|
☔ The latest upstream changes (presumably #128360) made this pull request unmergeable. Please resolve the merge conflicts. |
tgross35
force-pushed
the
f16-format-parse
branch
from
2eaa479 to
422c52e
Compare
Dylan-DPC
added
S-waiting-on-author
tgross35
force-pushed
the
f16-format-parse
branch
6 times, most recently
from
21ffabc to
2098f01
Compare
rustbot
added
the
T-bootstrap
tgross35
force-pushed
the
f16-format-parse
branch
5 times, most recently
from
404089f to
3636530
Compare
tgross35
force-pushed
the
f16-format-parse
branch
2 times, most recently
from
6840636 to
bea36a2
Compare
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 14, 2025
Add `f16` formatting and parsing Use the same algorithms as for `f32` and `f64` to implement `f16` parsing and printing. try-job: aarch64-gnu
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
bors
added
the
S-waiting-on-author
tgross35
force-pushed
the
f16-format-parse
branch
2 times, most recently
from
7d0475a to
4638679
Compare
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2025
Add `f16` formatting and parsing Use the same algorithms as for `f32` and `f64` to implement `f16` parsing and printing. try-job: aarch64-gnu try-job: dist-s390x-linux try-job: x86_64-mingw-1 try-job: x86_64-mingw-2
|
☀️ Try build successful - checks-actions |
|
@Mark-Simulacrum the only thing that changed from the original approval should be the addition of the fallback. I double checked with Bjorn and there shouldn’t be any problems with that. @rustbot ready |
rustbot
added
S-waiting-on-review
library/core/src/num/dec2flt/mod.rs
Outdated
| // FIXME(f16_f128): A fallback is used when the backend+target does not support f16 well, in order | ||
| // to avoid ICEs. | ||
|
|
||
| // After the bootstrap bump this should be: `#[cfg(not(target_has_reliable_f16))` |
There was a problem hiding this comment.
If true, please write this as a pair of cfg_attrs not a comment - we have some partial automation that can find and replace cfg attrs automatically but comments are near invisible to that.
There was a problem hiding this comment.
That is indeed not correct, the comment is from before the post-bump rebase. Removed.
Use the existing Lemire (decimal -> float) and Dragon / Grisu algorithms (float -> decimal) to add support for `f16`. This allows updating the implementation for `Display` to the expected behavior for `Display` (currently it prints the a hex bitwise representation), matching other floats, and adds a `FromStr` implementation. In order to avoid crashes when compiling with Cranelift or on targets where f16 is not well supported, a fallback is used if `cfg(target_has_reliable_f16)` is not true.
Extend the existing tests for `f32` and `f64` with versions that include `f16`'s new printing and parsing implementations. Co-authored-by: Speedy_Lex <[email protected]>
This requires a fix to the subnormal test to cap the maximum allowed value within the maximum mantissa.
tgross35
force-pushed
the
f16-format-parse
branch
from
4638679 to
221d7f3
Compare
|
@bors r=Mark-Simulacrum |
bors
added
S-waiting-on-bors
hkBst
added a commit
to hkBst/rust
that referenced
this pull request
May 16, 2025
…Simulacrum Add `f16` formatting and parsing Use the same algorithms as for `f32` and `f64` to implement `f16` parsing and printing. try-job: aarch64-gnu try-job: dist-s390x-linux try-job: x86_64-mingw-1 try-job: x86_64-mingw-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same algorithms as for
f32andf64to implementf16parsing and printing.try-job: aarch64-gnu
try-job: dist-s390x-linux
try-job: x86_64-mingw-1
try-job: x86_64-mingw-2